Skip to content

feat: dynamic colors - #794

Merged
Livinglist merged 1 commit into
Livinglist:masterfrom
eames-palmer:feat/dynamic-colors
Aug 7, 2026
Merged

feat: dynamic colors#794
Livinglist merged 1 commit into
Livinglist:masterfrom
eames-palmer:feat/dynamic-colors

Conversation

@eames-palmer

@eames-palmer eames-palmer commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Revision 1 Changes

  1. Adds Material You dynamic colors support and preference toggle.
  2. Handles conflicts with Accent Color and HackerNews theme selection gracefully.
  3. Limits platform to Android.
  4. Adds generic support for conflict exceptions on dependencies.

Why

  • 1.1: Improves consistency across applications when using dynamic colors system-wide.
  • 1.2: Prevents conflicts between other color selections while allowing for fonts, theme, and true black selections to remain.
  • 1.3: Material You is an Android exclusive feature.
  • 1.4: More scalable approach to adding new dependencies and displaying conflict errors to users.

Testing

  • Built the debug .apk and tested dynamic colors as well as conflict resolution.

  • Tested on Android 17 with Build Android APK workflow.

  • Dynamic Colors attempting to click Hacker News Theme toggle (or Accent Colors):

    Screenshot_20260805-225804

  • Dynamic Colors with True Black:

    Screenshot_20260805-230608

  • Hacker News Theme attempting to click Dynamic Colors toggle:

    Screenshot_20260805-230518

Related Links

@eames-palmer eames-palmer mentioned this pull request Aug 5, 2026
Open
@Livinglist

Livinglist commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Hi @eames-palmer thank you for doing this! Really good stuff, I will take a look later

@eames-palmer
eames-palmer force-pushed the feat/dynamic-colors branch 2 times, most recently from 4026a79 to 666616b Compare August 6, 2026 04:28
@eames-palmer

eames-palmer commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

This should now have the mutual exclusive logic with some refactoring to account for larger dependency graphs in the future.

Please let me know if you want any other changes or catch any bugs!

@eames-palmer
eames-palmer marked this pull request as ready for review August 6, 2026 06:15
@Livinglist
Livinglist merged commit 6eb2a42 into Livinglist:master Aug 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eames-palmer @Livinglist